[PATCH] D83069: [lit] warn if explicitly specified test won't be run indirectly

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 11 19:29:24 PDT 2020


thakis added inline comments.


================
Comment at: llvm/utils/lit/lit/discovery.py:162
+            for res in lc.test_format.getTestsInDirectory(ts, test_dir_in_suite,
+                                                          litConfig, lc):
+                if test.getFullName() == res.getFullName():
----------------
This looks potentially slow. Did you do any perf measurements for this patch? What's lit test discovery time for some target (say, check-llvm) for this test vs without? (min-of-5, or ministat)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83069/new/

https://reviews.llvm.org/D83069





More information about the llvm-commits mailing list