[PATCH] D83351: [llvm-reduce] Reducing attributes

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 11 16:46:59 PDT 2020


dblaikie added a comment.

> In D83351#2139879 <https://reviews.llvm.org/D83351#2139879>, @nickdesaulniers wrote:
> 
>> In D83351#2139818 <https://reviews.llvm.org/D83351#2139818>, @lebedev.ri wrote:
>>
>> > so i'm still waiting on the link/patch.
>>
>>
>> Treat your fellow contributors with more respect, please.  I know style disagreements aren't exciting, but we're all on the same team.
> 
> 
> Please remember that any [self-respecting] community is diverse, and almost by definition
>  that includes people with different 'base' languages. American speak of sugar-coating
>  very message is neither universally-used nor is required,
>  and not always following it does not mean ill-intent.

Sure enough - though the response did feel rather dismissive to me. I was explaining why I felt that the stylistic guidance was merited, but also wasn't what I think is best for the style guide (I think there's a lot of things that would be considered less readable that we can't encode in the style guide due to there being too many of them - that matter doesn't seem to have been answered/engaged with) and your response seemed to ignore the merits of that and abruptly repeat your point.

It's important for diversity to also create a welcoming community - that's not necessarily sugar coating, but engaging with kindness and understanding to other folks & hopefully be able to engage with the discussion in productive ways. None of us get this perfect all the time, to be sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351





More information about the llvm-commits mailing list