[PATCH] D83417: GlobalISel: Restructure argument lowering loop in handleAssignments

[Matt Arsenault via Phabricator via llvm-commits]

arsenm updated this revision to Diff 277264.
arsenm added a comment.
Herald added subscribers: kerbowa, nhaehnle, jvesely.

Use LocVT, which this code should have been using in the first place which avoids shrinking the store.

I also found the 2 forms of assignValueToAddress confusing, and the full form interface can't handle the case where a single stack slot covers multiple registers (although it seems unlikely this would ever be needed)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83417/new/

https://reviews.llvm.org/D83417

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
  llvm/test/CodeGen/AArch64/GlobalISel/call-lowering-i128-on-stack.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83417.277264.patch
Type: text/x-patch
Size: 12001 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200711/8477fedb/attachment.bin>