[PATCH] D83560: [DebugInfo] Added support for DW_OP_implicit_value in llvm

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

Sure, I understand the need having specific name(and my mistake of choosing a generic name `addImplicitValue` for the purpose of this patch). I've noted down and work on your inputs/concerns and revise once @aprantl and @probinson also have a look on it. Thanks again for your inputs :)

Regarding that strange check(80 bit width), at that time I didn't find a way to distinguish b/w `float` and `long double` so I did it in a brute force fashion(IEEE representation to distinguish). I'll see if I can do it better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560