[PATCH] D83185: [Attributor] Introduce Attribute seed allow list.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

> It would have been great if we had a way of telling whether a name is valid or not. Perhaps we could have a list of valid attribute names.

Let's not worry about that too much now. It seems an empty list doesn't make sense and when people pass garbage they'll get something.

One nit below and one idea but otherwise LGTM.

We could set the seeding to false if the list is empty to avoid looking up if it is empty all the time. Feel free to ignore.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1432
+  /// Wheather attributes are being `seeded`, always false after ::run function
+  /// gets called see getOrCreateAAFor.
+  bool SeedingPeriod = true;
----------------
Nit: `called. \see ...`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83185/new/

https://reviews.llvm.org/D83185