[llvm] 4500db8 - Revert "Reland "[InstCombine] Lower infinite combine loop detection thresholds"""

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 11 03:53:55 PDT 2020


Author: Roman Lebedev
Date: 2020-07-11T13:53:24+03:00
New Revision: 4500db8c59621a31c622862a2946457fdee481ce

URL: https://github.com/llvm/llvm-project/commit/4500db8c59621a31c622862a2946457fdee481ce
DIFF: https://github.com/llvm/llvm-project/commit/4500db8c59621a31c622862a2946457fdee481ce.diff

LOG: Revert "Reland "[InstCombine] Lower infinite combine loop detection thresholds"""

And there's a new hit: https://bugs.llvm.org/show_bug.cgi?id=46680
This reverts commit 7103c87596efccd532e9fe04a6ba6a200fed8481.

Added: 
    

Modified: 
    llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
index e810b3de25bc..d1c1e5418825 100644
--- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -123,13 +123,8 @@ STATISTIC(NumReassoc  , "Number of reassociations");
 DEBUG_COUNTER(VisitCounter, "instcombine-visit",
               "Controls which instructions are visited");
 
-// FIXME: these limits eventually should be as low as 2.
 static constexpr unsigned InstCombineDefaultMaxIterations = 1000;
-#ifndef NDEBUG
-static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 100;
-#else
 static constexpr unsigned InstCombineDefaultInfiniteLoopThreshold = 1000;
-#endif
 
 static cl::opt<bool>
 EnableCodeSinking("instcombine-code-sinking", cl::desc("Enable code sinking"),


        


More information about the llvm-commits mailing list