[PATCH] D83584: [AMDGPU] Move LowerSwitch pass to CodeGenPrepare.

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 21:42:00 PDT 2020


sameerds added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:790
     addPass(createLoadStoreVectorizerPass());
+
+  addPass(createLowerSwitchPass());
----------------
arsenm wrote:
> Can you add a comment for why this is here
The comment shouldn't record where the pass used to be. That is all in git history. But it should explain why this point is the correct place in the flow. Consider it as hint you would want to leave a future programmer if they discovered a reason to move the pass yet again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83584/new/

https://reviews.llvm.org/D83584





More information about the llvm-commits mailing list