[PATCH] D78283: [MustExecute] Use MustBeExecutedInterval to eliminate work duplication

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 15:09:20 PDT 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

Alright, this has been up for review long enough :)

Large diffs are indeed scary, and impossible to review,
and there is not really a way for people to mark parts
as reviewed so if i'm not the first one reviewing,
i guess no one has spotted anything bad yet.

This is pretty self-contained, in a pretty new (attributor) area.
Cursory examination suggests that this looks about right.
I suspect the perf story is indeed better than what there currently is :S

So i feel like i'm okay with rubber-stamping it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78283/new/

https://reviews.llvm.org/D78283





More information about the llvm-commits mailing list