[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D83578#2144828 <https://reviews.llvm.org/D83578#2144828>, @sammccall wrote:

> I believe if we do this without removing the substitutions, we're effectively running `EXE=$(command -v /full/path/to/llvm-ranlib)` which is a bit weird and IMO  doesn't make sense as a final state.
>
> I haven't done much investigation into the history/motivation of these substitutions, but I imagine we can remove at least some of them, and I'm happy to help out.


Agreed that the lit feature is weird and should be removed. AFAIK I don't think the feature is used in other places. We should be able to drop the feature.

> How do you think we should sequence this?

Apologies that as a non-native speaker I don't know what "sequence" means in the sentence. If you mean "dropping the feature from lit", are you signing off for the work? :) I'd be happy to review (I don't know enough about lit to locate the feature...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578