[PATCH] D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

This broke the modules build on macOS.

  warning: /Applications/Xcode5.app/Contents/Developer/Toolchains/OSX10.15.xctoolchain/usr/bin/libtool: warning for library: lib/libLLVMExtensions.a the table of contents is empty (no object file members in the library define global symbols)
  [320/3939] Building CXX object lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkLinker.cpp.o
  FAILED: lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkLinker.cpp.o 
  /Applications/Xcode5.app/Contents/Developer/Toolchains/OSX10.15.xctoolchain/usr/bin/c++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Remarks -I/Users/davide/work/llvm-project/llvm/lib/Remarks -I/Applications/Xcode5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.Internal.sdk/usr/include/libxml2 -Iinclude -I/Users/davide/work/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -fmodules -fmodules-cache-path=/Users/davide/work/build-modules/module.cache -fcxx-modules -Xclang -fmodules-local-submodule-visibility -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -O3  -isysroot /Applications/Xcode5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.Internal.sdk    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkLinker.cpp.o -MF lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkLinker.cpp.o.d -o lib/Remarks/CMakeFiles/LLVMRemarks.dir/RemarkLinker.cpp.o -c /Users/davide/work/llvm-project/llvm/lib/Remarks/RemarkLinker.cpp
  While building module 'LLVM_Object' imported from /Users/davide/work/llvm-project/llvm/include/llvm/Remarks/RemarkLinker.h:16:
  While building module 'LLVM_IR' imported from /Users/davide/work/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:
  While building module 'LLVM_intrinsic_gen' imported from /Users/davide/work/llvm-project/llvm/include/llvm/IR/IRPrintingPasses.h:22:
  In file included from <module-includes>:1:
  In file included from /Users/davide/work/llvm-project/llvm/include/llvm/IR/Argument.h:18:
  /Users/davide/work/llvm-project/llvm/include/llvm/IR/Attributes.h:75:14: fatal error: 'llvm/IR/Attributes.inc' file not found
      #include "llvm/IR/Attributes.inc"
               ^~~~~~~~~~~~~~~~~~~~~~~~
  While building module 'LLVM_Object' imported from /Users/davide/work/llvm-project/llvm/include/llvm/Remarks/RemarkLinker.h:16:
  While building module 'LLVM_IR' imported from /Users/davide/work/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:
  In file included from <module-includes>:4:
  /Users/davide/work/llvm-project/llvm/include/llvm/IR/IRPrintingPasses.h:22:10: fatal error: could not build module 'LLVM_intrinsic_gen'
  #include "llvm/IR/PassManager.h"
   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
  While building module 'LLVM_Object' imported from /Users/davide/work/llvm-project/llvm/include/llvm/Remarks/RemarkLinker.h:16:
  In file included from <module-includes>:4:
  /Users/davide/work/llvm-project/llvm/include/llvm/Object/IRSymtab.h:29:10: fatal error: could not build module 'LLVM_IR'
  #include "llvm/IR/GlobalValue.h"
   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
  In file included from /Users/davide/work/llvm-project/llvm/lib/Remarks/RemarkLinker.cpp:13:
  /Users/davide/work/llvm-project/llvm/include/llvm/Remarks/RemarkLinker.h:16:10: fatal error: could not build module 'LLVM_Object'
  #include "llvm/Object/ObjectFile.h"
   ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
  4 errors generated.

I'm going to revert, and I'm going to follow up with precise instructions on how to repro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83498/new/

https://reviews.llvm.org/D83498