[PATCH] D83562: [fix-irreducible] Skip unreachable predecessors.

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 09:42:12 PDT 2020


hliao added a comment.

In D83562#2144432 <https://reviews.llvm.org/D83562#2144432>, @sameerds wrote:

> @cdevadas reported that other parts of the AMDGPU backend are also affected by the unreachable blocks being produced in the switch lowering. Instead of fixing each such pass separately, it seems the best way forward it to put the block elimination earlier in the flow. @cdevadas is already working on such a change.


I understand the cleanup of switch-lower pass could avoid the issue. But, as a general pass, it should be prepared to handle the general cases similar to other general passes. Also, it's a blocking issue to our schedule. Could you review this trivial change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83562/new/

https://reviews.llvm.org/D83562





More information about the llvm-commits mailing list