[PATCH] D78663: [builtins] Add 32-bit shift builtins

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 10 08:55:13 PDT 2020


aykevl marked an inline comment as done.
aykevl added inline comments.


================
Comment at: compiler-rt/lib/builtins/int_types.h:46-65
+#if _YUGA_LITTLE_ENDIAN
+    hu_int low;
+    hi_int high;
+#else
+    hi_int high;
+    hu_int low;
+#endif // _YUGA_LITTLE_ENDIAN
----------------
luismarques wrote:
> Are these macro definitions processor-specific? If so, can't we use something more general?
I'm not sure what `YUGA` means exactly. The constants are defined in int_endianness.h and are also used in various other places in int_types.h (this file). I'm just following the existing convention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78663/new/

https://reviews.llvm.org/D78663





More information about the llvm-commits mailing list