[PATCH] D83246: [Attributor] use liveness information from AAIsDead in AAReachability and cache query results

[Shinji Okumura via Phabricator via llvm-commits]

okura marked an inline comment as done.
okura added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:729
+    return Result;
+  }
+
----------------
jdoerfert wrote:
> Please add documentation and consider taking the instructions as references.
> 
> Nit: Move `F` after the first check to shorten the lifetime (and avoid confusion).
> 
Do you expect that I change interfaces of AAReachability to take instructions as references too?
Could you tell me the advantage of taking as references compared to taking as pointers? I don't mean I want to stick to pointers, just want to know about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83246/new/

https://reviews.llvm.org/D83246