[PATCH] D82816: [PowerPC] Implement R_PPC64_REL24_NOTOC local calls, callee also has no TOC

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:13
+# RUN: ld.lld -T %t.script -shared %t1.o %t2.o -o %t.so
+# RUN: ld.lld -T %t.script %t3.o -o %t
+# RUN: llvm-readelf -s %t.so | FileCheck %s --check-prefix=SYMBOL
----------------
sfertile wrote:
> Nit: I suggest having a separate set of run steps for testing the exec since the steps are completely disjoint from the shared object test. ie separate out
> ```
> # RUN: llvm-mc -filetype=obj -triple=powerpc64[le] -defsym GLOBAL=1 %s -o %t3.o
> # RUN: ld.lld -T %t.script %t3.o -o %t
> # RUN: llvm-readelf -s %t | FileCheck %s --check-prefix=SYMBOL-GLOBAL
> # RUN: llvm-objdump -d --no-show-raw-insn --mcpu=pwr10 %t | FileCheck %s
> ```
> 
Thanks. Addressed the nit when committing the patch. 


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-pcrel.s:60
+  .localentry caller1, 1
+  # nop is not needed after bl for R_PPC64_REL24_NOTOC
+  bl callee1_stother0_default at notoc
----------------
MaskRay wrote:
> We use `## ` for comments.
Thanks. Addressed the nit when committing the patch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816