[PATCH] D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:300
 
-namespace {
+namespace llvm {
 
----------------
aeubanks wrote:
> ychen wrote:
> > How about keeping this local? These are only for testing.
> Do you mean keeping this in an anonymous namespace?
> As mentioned in the commit, that makes the printed name messed up.
Add some regex in lit tests?
Running pass: {{.*}}NoOpModulePass



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83498/new/

https://reviews.llvm.org/D83498