[PATCH] D83498: [NFC] Derive from PassInfoMixin for no-op/printing passes

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 11:52:01 PDT 2020


aeubanks created this revision.
aeubanks added reviewers: ychen, asbirlea, hans.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

PassInfoMixin should be used for all NPM passes, rater than a custom
`name()`.

This caused ambiguous references in LegacyPassManager.cpp, so had to
remove "using namespace llvm::legacy" and move some things around.

The passes had to be moved to the llvm namespace, or else they would get
printed as "(anonymous namespace)::FooPass".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83498

Files:
  llvm/include/llvm/IR/IRPrintingPasses.h
  llvm/lib/IR/LegacyPassManager.cpp
  llvm/lib/Passes/PassBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83498.276796.patch
Type: text/x-patch
Size: 14677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/0abb021f/attachment.bin>


More information about the llvm-commits mailing list