[PATCH] D83432: [NFC][llvm-reduce] Don't `rm -rf` in tests, `rm -f` is enough

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 10:49:41 PDT 2020


dblaikie added a comment.

In D83432#2141025 <https://reviews.llvm.org/D83432#2141025>, @lebedev.ri wrote:

> In D83432#2140532 <https://reviews.llvm.org/D83432#2140532>, @dblaikie wrote:
>
> > If the test is writing the output file anyway - is the rm necessary? (lots of tests write to output files via "-o %t" from some tool or another and most don't delete %t before doing so)
>
>
> They were added by you in rL372054 <https://reviews.llvm.org/rL372054>, so indeed the revert of that commit would be the best solution now.


Thought it might've been my fault :) great - removed in 8769611f0af2598177d8d03ad6dbbe064210bfed <https://reviews.llvm.org/rG8769611f0af2598177d8d03ad6dbbe064210bfed>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83432/new/

https://reviews.llvm.org/D83432





More information about the llvm-commits mailing list