[PATCH] D83372: Fix for memory leak reported by Valgrind

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 07:41:29 PDT 2020


beanz added a comment.

Logically your patch here looks fine. I'd rather see it use a `std::lock_guard` as the original code did, with a nested scope added, but that is pretty nitpicky.

Also the code doesn't conform to LLVM's coding standards for variable naming (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83372/new/

https://reviews.llvm.org/D83372





More information about the llvm-commits mailing list