[PATCH] D82923: introducing llvm-libtool-darwin

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 4 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/hide-unrelated-options.test:1
+## This test checks that unrelated options are hidden in help text.
+
----------------
jhenderson wrote:
> This is probably fine, but an alternative that might be more consistent is to expand help-message.test to show that the option categories that should be supported are printed (by checking the e.g. "Color options:" text), and that the unrelated options aren't (by similarly checking that the header for them isn't included). There are some examples of this for some tools like llvm-size. You might also want to add a --help-list test case as in llvm-size's help.test.
ok, I have modeled `help.test` under `llvm-libtool-darwin` in a similar fashion as `llvm-size`. Thanks! (I have also removed `hide-unrelated-options.test` now).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923