[PATCH] D82763: MIR: Infer not-SSA for subregister defs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 07:28:52 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineRegisterInfo.h:453
+  /// specified register, otherwise nullptr.
+  MachineOperand *getOneDef(Register Reg) const {
+    def_iterator DI = def_begin(Reg);
----------------
thegameg wrote:
> There is a `MachineInstr *getUniqueVRegDef(Register Reg) const;`. Maybe name this one `getUniqueVRegDefOperand`? Are they actually vreg-only?
I guess this would technically work for physical registers. I picked the name to mirror the existing hasOneDef just above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82763/new/

https://reviews.llvm.org/D82763





More information about the llvm-commits mailing list