[PATCH] D83313: [MachineOutliner] Fix liveness computing.

Yvan Roux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 06:14:58 PDT 2020


yroux added a comment.

In D83313#2137190 <https://reviews.llvm.org/D83313#2137190>, @efriedma wrote:

> I'm not really happy with this approach; if LiveRegUnits isn't producing correct results, we should fix it, not try to hack around it.
>
> Maybe we should revive D40061 <https://reviews.llvm.org/D40061>...


My attempt wasn't to to hack around it, but to calculate the LiveRegUnit accurately ;-) Sorry I wasn't working on LLVM when you proposed D40061 <https://reviews.llvm.org/D40061>, but it is indeed a better approach, can you re-open it ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83313/new/

https://reviews.llvm.org/D83313





More information about the llvm-commits mailing list