[PATCH] D83203: [CodeGen] Fix warnings in SelectionDAG::SplitVector

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 05:57:55 PDT 2020


sdesmalen added a comment.

Can you please clarify the title/summary a bit more before committing the patch?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:9628
   Hi = getNode(ISD::EXTRACT_SUBVECTOR, DL, HiVT, N,
-               getVectorIdxConstant(LoVT.getVectorNumElements(), DL));
+               getVectorIdxConstant(LoVT.getVectorMinNumElements(), DL));
   return std::make_pair(Lo, Hi);
----------------
nit: can you add a comment explaining why `getVectorMinNumElements()` is valid here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83203/new/

https://reviews.llvm.org/D83203





More information about the llvm-commits mailing list