[PATCH] D83452: [DWARFYAML] Virtual functions should be overridden in derived class.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 01:43:05 PDT 2020


grimar added a comment.

Also, I find the description a bit confusing:

> Virtual functions should be overridden in the derived class

Isn't this change (virtual->override) here a no-op to improve the code style?
All these funtions are anyways overriden, with the `override` word or without it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83452/new/

https://reviews.llvm.org/D83452





More information about the llvm-commits mailing list