[PATCH] D83460: Fix HexagonGenExtract return statu

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 01:11:26 PDT 2020


serge-sans-paille created this revision.
serge-sans-paille added reviewers: kparzysz, foad, jdoerfert.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Correctly reflect change in the return status.

Patch needed to land https://reviews.llvm.org/D80916


https://reviews.llvm.org/D83460

Files:
  llvm/lib/Target/Hexagon/HexagonGenExtract.cpp


Index: llvm/lib/Target/Hexagon/HexagonGenExtract.cpp
===================================================================
--- llvm/lib/Target/Hexagon/HexagonGenExtract.cpp
+++ llvm/lib/Target/Hexagon/HexagonGenExtract.cpp
@@ -221,15 +221,16 @@
 }
 
 bool HexagonGenExtract::visitBlock(BasicBlock *B) {
+  bool Changed = false;
+
   // Depth-first, bottom-up traversal.
   for (auto *DTN : children<DomTreeNode*>(DT->getNode(B)))
-    visitBlock(DTN->getBlock());
+    Changed |= visitBlock(DTN->getBlock());
 
   // Allow limiting the number of generated extracts for debugging purposes.
   bool HasCutoff = ExtractCutoff.getPosition();
   unsigned Cutoff = ExtractCutoff;
 
-  bool Changed = false;
   BasicBlock::iterator I = std::prev(B->end()), NextI, Begin = B->begin();
   while (true) {
     if (HasCutoff && (ExtractCount >= Cutoff))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83460.276651.patch
Type: text/x-patch
Size: 841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/d34618c9/attachment-0001.bin>


More information about the llvm-commits mailing list