[PATCH] D82858: [llvm-objdump] Detect note section for ELF objects

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 01:11:25 PDT 2020


jhenderson added a comment.

In D82858#2139642 <https://reviews.llvm.org/D82858#2139642>, @scott.linder wrote:

> > In an ideal world, we'd merge all the binary tools (GNU and LLVM) into a single tool, or redistribute functionality somehow, so that we don't have duplicate functionality like we already do. This takes us further away from that ideal.
>
> I'm confused by this statement in particular. If the goal is to just have one tool, why did LLVM start re-implementing these tools to begin with? Wasn't the first commit of "llvm-objdump"/"llvm-readobj" a massive step away from the ideal?


I'm afraid I can't answer that question. I joined LLVM development quite some time after both llvm-readobj and llvm-objdump were initially created. My suspicion is that llvm-readobj was created to provide a generic testing facility, llvm-readelf (i.e. GNU output style for llvm-readobj) was later added for GNU compatiblity, and llvm-objdump was created for disassembly, with GNU compatibility features such as section header printing added later on. However, I haven't attempted to research any of this in depth, so I could easily see this being wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82858/new/

https://reviews.llvm.org/D82858





More information about the llvm-commits mailing list