[PATCH] D83457: Fix return status of AtomicExpandPass

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 00:39:49 PDT 2020


serge-sans-paille created this revision.
serge-sans-paille added reviewers: arsenm, asb, foad, jdoerfert.
Herald added subscribers: llvm-commits, hiraditya, wdng.
Herald added a project: LLVM.

Correctly reflect change in the return status.

Patch needed to land https://reviews.llvm.org/D80916


https://reviews.llvm.org/D83457

Files:
  llvm/lib/CodeGen/AtomicExpandPass.cpp


Index: llvm/lib/CodeGen/AtomicExpandPass.cpp
===================================================================
--- llvm/lib/CodeGen/AtomicExpandPass.cpp
+++ llvm/lib/CodeGen/AtomicExpandPass.cpp
@@ -1447,8 +1447,10 @@
   default:
     llvm_unreachable("Unhandled case in tryExpandAtomicCmpXchg");
   case TargetLoweringBase::AtomicExpansionKind::None:
-    if (ValueSize < MinCASSize)
+    if (ValueSize < MinCASSize) {
       expandPartwordCmpXchg(CI);
+      return true;
+    }
     return false;
   case TargetLoweringBase::AtomicExpansionKind::LLSC: {
     return expandAtomicCmpXchg(CI);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83457.276643.patch
Type: text/x-patch
Size: 596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/bce38a33/attachment.bin>


More information about the llvm-commits mailing list