[PATCH] D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 22:18:11 PDT 2020


plotfi added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:241
+
+bool AArch64FrameLowering::producePairRegisters(MachineFunction &MF) const {
+  return produceCompactUnwindFrame(MF) || homogeneousPrologEpilog(MF);
----------------
This is so small that I feel it would be more descriptive at the call site of SavedRegs.set/test to have:

```
/// true if CSRs should be paired
const bool producePairRegisters = produceCompactUnwindFrame(MF) || homogeneousPrologEpilog(MF);
```

With some additional comments on the register paring in the context of homogenous-prolog-epilog.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76570/new/

https://reviews.llvm.org/D76570





More information about the llvm-commits mailing list