[llvm] 18bd821 - DAG: Remove redundant finalizeLowering call

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 15:48:27 PDT 2020


Author: Matt Arsenault
Date: 2020-07-08T18:48:20-04:00
New Revision: 18bd821f02261065a2235e43c7290b57d55224c8

URL: https://github.com/llvm/llvm-project/commit/18bd821f02261065a2235e43c7290b57d55224c8
DIFF: https://github.com/llvm/llvm-project/commit/18bd821f02261065a2235e43c7290b57d55224c8.diff

LOG: DAG: Remove redundant finalizeLowering call

9cac4e6d1403554b06ec2fc9d834087b1234b695/D32628 intended to eliminate
this, and move all isel pseudo expansion to FinalizeISel. This was a
bad rebase or something, and failed to actually delete this call.

GlobalISel also has a redundant call of finalizeLowering. However, it
requires more work to remove it since it currently triggers a lot of
verifier errors in tests.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
index df0ce502a059..1f0432196a2d 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -661,8 +661,6 @@ bool SelectionDAGISel::runOnMachineFunction(MachineFunction &mf) {
   // Determine if floating point is used for msvc
   computeUsesMSVCFloatingPoint(TM.getTargetTriple(), Fn, MF->getMMI());
 
-  TLI->finalizeLowering(*MF);
-
   // Release function-specific state. SDB and CurDAG are already cleared
   // at this point.
   FuncInfo->clear();


        


More information about the llvm-commits mailing list