[PATCH] D83351: [llvm-reduce] Reducing attributes

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 14:51:26 PDT 2020


nickdesaulniers added a comment.

In D83351#2140189 <https://reviews.llvm.org/D83351#2140189>, @lebedev.ri wrote:

> In D83351#2140177 <https://reviews.llvm.org/D83351#2140177>, @nickdesaulniers wrote:
>
> > In D83351#2140113 <https://reviews.llvm.org/D83351#2140113>, @lebedev.ri wrote:
> >
> > > I will split this up into several commits when landing.
> >
> >
> > What's the plan?
>
>
> langref(?), test cleanup, for_each cleanup, rest of the patch


SGTM, if you want to split those off in child revisions/phab reviews I'd be happy to review/approve test cleanup, for_each, and the rebased patch for this feature.

I think you meant coding standard (as opposed to langref)? (Just checking, or was there a LangRef change, too, and I missed it?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351





More information about the llvm-commits mailing list