[PATCH] D83351: [llvm-reduce] Reducing attributes

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 276552.
lebedev.ri added a reviewer: arsenm.
lebedev.ri added a comment.
Herald added a subscriber: wdng.

Addressing nits:

- It turns out, we can't add attributes to true intrinsics, so indeed, there is no point in trying to reduce them. Originally, i thought that wasn't the case and didn't want to deal with all that (with having to understand which attribute will just reappear if it is deleted) right away. So just ignore true intrinsics.
- for_each changes

I will split this up into several commits when landing.

In D83351#2139879 <https://reviews.llvm.org/D83351#2139879>, @nickdesaulniers wrote:

> In D83351#2139818 <https://reviews.llvm.org/D83351#2139818>, @lebedev.ri wrote:
>
> > so i'm still waiting on the link/patch.
>
>
> Treat your fellow contributors with more respect, please.  I know style disagreements aren't exciting, but we're all on the same team.


Please remember that any [self-respecting] community is diverse, and almost by definition
that includes people with different 'base' languages. American speak of sugar-coating
very message is neither universally-used nor is required,
and not always following it does not mean ill-intent.

> I much prefer LLVM's community to the Linux kernel's for a reason, and I think it's worthwhile to speak up in defense of it, lest it decay.  I'm not the best at maintaining this myself, so if you see me break my own standards, please feel empowered to call me out.
> 
> Another benefit of range for here is we don't need the braces, so these can be 2 lines instead of 3.  Please change them to be consistent.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351

Files:
  llvm/docs/CodingStandards.rst
  llvm/test/Reduce/remove-args.ll
  llvm/test/Reduce/remove-attributes-from-intrinsic-like-functions.ll
  llvm/test/Reduce/remove-attributes-from-intrinsics.ll
  llvm/test/Reduce/remove-call-site-attributes.ll
  llvm/test/Reduce/remove-funcs.ll
  llvm/test/Reduce/remove-function-attributes.ll
  llvm/test/Reduce/remove-global-variable-attributes.ll
  llvm/test/Reduce/remove-global-vars.ll
  llvm/test/Reduce/remove-metadata.ll
  llvm/test/Reduce/remove-multiple-use-of-args-in-same-instruction.ll
  llvm/test/Reduce/remove-multiple-use-of-global-vars-in-same-instruction.ll
  llvm/test/Reduce/remove-operand-bundles.ll
  llvm/tools/llvm-reduce/CMakeLists.txt
  llvm/tools/llvm-reduce/DeltaManager.h
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.h
  llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp
  llvm/utils/gn/secondary/llvm/tools/llvm-reduce/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83351.276552.patch
Type: text/x-patch
Size: 22549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/71ba121e/attachment.bin>