[PATCH] D82998: [BasicAA] Enable -basic-aa-recphi by default

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In D82998#2138980 <https://reviews.llvm.org/D82998#2138980>, @dmgreen wrote:

> It should be triggering relatively often, from looking at the tests/benchmarks I was seeing. Any code that uses pointer induction variables can trigger it. Whether that will common will be a matter of the style of the original code, and whether it actually proves move NoAlias will be variable. But it seems to come up enough to make code improvements in a fair number of cases.
>
> From what I can tell it should be almost free though, in terms of compile time. Just an extra check of whether a phi is a simple recursion.


Baseline checks are generally self hosting and running the test suite. Make sure that everything looks clean. Check for regressions (compile time or execution time). Have you already done that? Also, checking on how many times this change triggers during that process is useful information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82998/new/

https://reviews.llvm.org/D82998