[PATCH] D83408: [SVE] Disable some BUILD_VECTOR related code generator features.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3569
+// them to expand BUILD_VECTOR.
+bool AArch64TargetLowering::shouldExpandBuildVectorWithShuffles(
+    EVT VT, unsigned DefinedValues) const {
----------------
Would it be enough to just fix isShuffleMaskLegal, instead of overriding this?


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:745
+  /// illegal as the original, thus leading to an infinite legalisation loop.
+  bool mergeStoresAfterLegalization(EVT VT) const override {
+    return !useSVEForFixedLengthVectors();
----------------
This affects code that isn't using wide vectors, right?

If this is supposed to be a temporary hack, I guess it's fine, but please explicitly state that in the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83408/new/

https://reviews.llvm.org/D83408