[llvm] 05ce9aa - Tighten description of ISD::BUILD_VECTOR

Cameron McInally via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 12:06:38 PDT 2020


Author: Cameron McInally
Date: 2020-07-08T14:06:23-05:00
New Revision: 05ce9aaa69f9f58598730895bdb5535fea17213f

URL: https://github.com/llvm/llvm-project/commit/05ce9aaa69f9f58598730895bdb5535fea17213f
DIFF: https://github.com/llvm/llvm-project/commit/05ce9aaa69f9f58598730895bdb5535fea17213f.diff

LOG: Tighten description of ISD::BUILD_VECTOR

VerifySDNode(...) in SelectionDAG.cpp shows that the operands of a BUILD_VECTOR must all be the same type. This patch cleans up the comment in ISDOpcodes.h to make that more obvious. Also, remove the requirement that the number of elements must be a power-of-2. That's not true.

Differential Revision: https://reviews.llvm.org/D83413

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/ISDOpcodes.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/ISDOpcodes.h b/llvm/include/llvm/CodeGen/ISDOpcodes.h
index d3ff99dee37f..d121a4d5427f 100644
--- a/llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ b/llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -448,11 +448,11 @@ enum NodeType {
   FCANONICALIZE,
 
   /// BUILD_VECTOR(ELT0, ELT1, ELT2, ELT3,...) - Return a fixed-width vector
-  /// with the specified, possibly variable, elements.  The number of elements
-  /// is required to be a power of two. The types of the operands must all be
-  /// the same and must match the vector element type, except that integer types
-  /// are allowed to be larger than the element type, in which case the operands
-  /// are implicitly truncated.
+  /// with the specified, possibly variable, elements. The types of the
+  /// operands must all be the same. The types of the operands must match the
+  /// vector element type, except that integer types are allowed to be larger
+  /// than the element type, in which case the operands are implicitly
+  /// truncated.
   BUILD_VECTOR,
 
   /// INSERT_VECTOR_ELT(VECTOR, VAL, IDX) - Returns VECTOR with the element


        


More information about the llvm-commits mailing list