[PATCH] D83412: [LLVM] Accept `noundef` attribute in function definitions/calls

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 11:33:24 PDT 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/IR/Attributes.td:42
 
+/// Parameter or return value may not contain uninitialized or poison bits
+def NoUndef : EnumAttr<"noundef">;
----------------
nit: Missing period at the end.


================
Comment at: llvm/lib/AsmParser/LLLexer.cpp:699
   KEYWORD(immarg);
+  KEYWORD(noundef);
 
----------------
It looks like apart from `immarg` this is sorted alphabetically, so I'd move `noundef` before `nounwind`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83412/new/

https://reviews.llvm.org/D83412





More information about the llvm-commits mailing list