[PATCH] D83361: [LLVM] Add libatomic load/store functions to TargetLibraryInfo

Gui Andrade via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 10:41:55 PDT 2020


guiand added a comment.

In D83361#2138409 <https://reviews.llvm.org/D83361#2138409>, @rovka wrote:

> Don't you also have to set as Available/Unavailable when initializing the TLI?


Yes, thanks for the catch! It looks like it's set available by default, there may be platforms that don't have these libatomic functions available.

>From a look at RuntimeLibCalls, where these functions are also used (for emitting), it looks like the functions are only explicitly made unavailable on webassembly. (Which is pretty surprising! Could I be missing something here?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83361/new/

https://reviews.llvm.org/D83361





More information about the llvm-commits mailing list