[PATCH] D81981: [PGO] Supplement PGO profile with Sample profile

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 10:22:42 PDT 2020


davidxl added a comment.

Can you first split the NFC part (refactoring part such as GetEntryForPercentile) out ?



================
Comment at: llvm/include/llvm/ProfileData/InstrProf.h:682
   /// Scale up value profile data counts.
-  void scale(uint64_t Weight, function_ref<void(instrprof_error)> Warn);
+  void scale(uint64_t Norm, uint64_t DeNorm,
+             function_ref<void(instrprof_error)> Warn);
----------------
document the parameters.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81981/new/

https://reviews.llvm.org/D81981





More information about the llvm-commits mailing list