[PATCH] D83384: [GlobalISel][InlineAsm] Fix buildCopy for inputs

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 09:59:53 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp:240
 
+static bool buildAnyextOrCopy(Register Dst, Register Src,
+                              MachineIRBuilder &MIRBuilder) {
----------------
Would `MachineIRBuilder::buildExtOrTrunc` work here?

If not, maybe it would make sense to move this to `MachineIRBuilder` for the sake of consistency?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83384/new/

https://reviews.llvm.org/D83384





More information about the llvm-commits mailing list