[PATCH] D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile marked an inline comment as done.
sfertile added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lld/ELF/Thunks.cpp:982
 
+  if ((s.stOther >> 5) == 1 && type == R_PPC64_REL24)
+    return make<PPC64R2SaveStub>(s);
----------------
stefanp wrote:
> MaskRay wrote:
> > This needs a comment.
> I've added a comment. 
> Adding the comment forced me to re-assess the condition statement so I've also changed the condition to be just:
> ```
> if ((s.stOther >> 5) == 1)
> ```
> There was no reason to exclude R_PPC64_REL14 from this condition.
> I have also added a test for R_PPC64_REL14.
👍 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82950/new/

https://reviews.llvm.org/D82950