[PATCH] D83397: [flang] Replace uses of _Complex with std::complex

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 07:44:31 PDT 2020


schweitz added a comment.

Hi Eric,

There is an active development branch for the flang middle end. https://github.com/flang-compiler/f18-llvm-project/tree/fir-dev

That code base is being upstreamed piecemeal. Not all of the code is upstreamed at this point. It is simply a false impression that code in the middle of being upstreamed is "unused" or "unnecessary". Since it not all of it is upstreamed, changing interfaces and support code in llvm-project directly is going to cause problems that can become hard to track and resolve while the upstreaming is ongoing.

Besides, there are plenty of compilation warnings in LLVM today, and many of them from personal experience have persisted for months before being resolved. This is not a unique case.

Is it possible to wait for the author to implement a solution?  Or if not, can we just disable the warning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83397/new/

https://reviews.llvm.org/D83397





More information about the llvm-commits mailing list