[PATCH] D83046: [LiveDebugValues] 1/4 Install an implementation-picking LiveDebugValues pass

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Super nits included.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:13
+#include "llvm/CodeGen/MachineFrameInfo.h"
+#include "llvm/CodeGen/MachineFunction.h"
+#include "llvm/CodeGen/MachineFunctionPass.h"
----------------
I think this include is redundant.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:1792
+  // Skip functions from NoDebug compilation units.
+  if (MF.getFunction().getSubprogram()->getUnit()->getEmissionKind() ==
+    DICompileUnit::NoDebug)
----------------
clang-format please


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83046/new/

https://reviews.llvm.org/D83046