[PATCH] D80916: [LegacyPM] Double check that passes correctly set their Modified status

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 03:48:02 PDT 2020


foad added a comment.

Looks good to me apart from the comments inline, but I'd like someone else to approve it too.

As a follow-up can we have the same checking for Loop, Region and SCC passes?



================
Comment at: llvm/lib/IR/LegacyPassManager.cpp:1490
+
+uint64_t FunctionHash(Function &F) {
+  StructuralHash H;
----------------
I don't like having both `functionHash` and `FunctionHash`. How about having `FunctionHash` take the initial hash value as an optional argument that defaults to StructuralHash() ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80916/new/

https://reviews.llvm.org/D80916





More information about the llvm-commits mailing list