[PATCH] D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3676
+  }
+}
+
----------------
gcc (7.4.0) warns with
../lib/MC/MCParser/MasmParser.cpp:3676:1: warning: control reaches end of non-void function [-Wreturn-type]
here.
It can be silenced with an llvm_unreachable if that's acceptable.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3829
+  }
+}
+
----------------
gcc 7.4.0 warning here too
../lib/MC/MCParser/MasmParser.cpp:3829:1: warning: control reaches end of non-void function [-Wreturn-type]



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3831
+
+bool MasmParser::emitStructValue(const StructInfo &Structure) {
+  size_t Offset = 0;
----------------
gcc warns that this method is unused. Will it be used or can it perhaps be removed?


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3908
+  }
+}
+
----------------
gcc 7.4.0 warning here too
../lib/MC/MCParser/MasmParser.cpp:3908:1: warning: control reaches end of non-void function [-Wreturn-type]



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75306/new/

https://reviews.llvm.org/D75306