[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

Tue Jul 7 22:08:42 PDT 2020

MaskRay added a comment.

I have studied CFIInstrInserter in May. If you don't mind, please give me some time to review as well.

For `basic-block-sections-cfiinstr_1.ll`, have you considered places like `CodeGen/X86/cfi-inserter-*`? You may even create a subdirectory there.
`_1` is not very common. `-1` is more common.

`curl -L 'https://reviews.llvm.org/D79978?download=1'` does not have a/ or b/ prefix. I think that may be why `arc patch D79978` cannot apply the patch.
Can you upload a diff with either `arc diff`, git format-patch -1 or `git diff 'HEAD^'`? Thanks.

================
Comment at: llvm/test/DebugInfo/X86/basic-block-sections-cfiinstr_1.ll:6
+; CFI_INSTR: _Z7computebiiiiii
+; CFI_INSTR: bb.0
+; CFI_INSTR: bb.1
----------------
I think these labels may need `:` suffix and a `# `prefix to make them unique.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978