[PATCH] D82816: [LLD][PowerPC] Implement R_PPC64_REL24_NOTOC calls, callee also has no TOC

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked an inline comment as done.
NeHuang added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1041
     return false;
 
   // If a function is in the Plt it needs to be called with a call-stub.
----------------
sfertile wrote:
> We should probably insert a couple of fatal error here:
> 1) if the type in NOTOC and the symbols st_other indicates it needs the toc-pointer setup.
> 2) If the type is not NOTOC but the symbols st_other indicates it tramples the toc.
Thanks Sean for the advice. I also moved the fatal error check for the protocol "external call with R_PPC64_REL_NOTOC" here so that we are checking all unimplemented protocols in the same function. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82816/new/

https://reviews.llvm.org/D82816