[PATCH] D83363: [openmp] Use switch in isAllowedClauseForDirective instead of multiple if
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 19:17:03 PDT 2020
clementval marked 2 inline comments as done.
clementval added inline comments.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:471
VersionedClause<OMPC_NumThreads>,
- VersionedClause<OMPC_DefaultMap>,
VersionedClause<OMPC_ProcBind>,
----------------
jdoerfert wrote:
> clementval wrote:
> > clementval wrote:
> > > jdoerfert wrote:
> > > > [Drive By] Unrelated?
> > > It was a duplicate. Already on line 469.
> > Makes compilation error because of duplicate case when code is generated.
> Commit NFC changes like that w/o review if it "just makes sense".
Ok! Good to know!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83363/new/
https://reviews.llvm.org/D83363
More information about the llvm-commits
mailing list