[compiler-rt] baca8f9 - [compiler-rt][Hexagon] Remove fma/fmin/max code

Sid Manning via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 17:50:30 PDT 2020


Author: Sid Manning
Date: 2020-07-07T19:50:04-05:00
New Revision: baca8f977edce6edb0f9074b77a38c753f8f0c79

URL: https://github.com/llvm/llvm-project/commit/baca8f977edce6edb0f9074b77a38c753f8f0c79
DIFF: https://github.com/llvm/llvm-project/commit/baca8f977edce6edb0f9074b77a38c753f8f0c79.diff

LOG: [compiler-rt][Hexagon] Remove fma/fmin/max code

This code should reside in the c-library.

Differential Revision: https://reviews.llvm.org/D82263

Added: 
    

Modified: 
    compiler-rt/lib/builtins/CMakeLists.txt
    compiler-rt/lib/builtins/hexagon/dffma.S

Removed: 
    compiler-rt/lib/builtins/hexagon/fabs_opt.S
    compiler-rt/lib/builtins/hexagon/fma_opt.S
    compiler-rt/lib/builtins/hexagon/fmax_opt.S
    compiler-rt/lib/builtins/hexagon/fmin_opt.S


################################################################################
diff  --git a/compiler-rt/lib/builtins/CMakeLists.txt b/compiler-rt/lib/builtins/CMakeLists.txt
index aa0df8d5bfdf..5e3c901322ec 100644
--- a/compiler-rt/lib/builtins/CMakeLists.txt
+++ b/compiler-rt/lib/builtins/CMakeLists.txt
@@ -505,13 +505,9 @@ set(hexagon_SOURCES
   hexagon/dfsqrt.S
   hexagon/divdi3.S
   hexagon/divsi3.S
-  hexagon/fabs_opt.S
   hexagon/fastmath2_dlib_asm.S
   hexagon/fastmath2_ldlib_asm.S
   hexagon/fastmath_dlib_asm.S
-  hexagon/fma_opt.S
-  hexagon/fmax_opt.S
-  hexagon/fmin_opt.S
   hexagon/memcpy_forward_vp4cp4n2.S
   hexagon/memcpy_likely_aligned.S
   hexagon/moddi3.S

diff  --git a/compiler-rt/lib/builtins/hexagon/dffma.S b/compiler-rt/lib/builtins/hexagon/dffma.S
index c201d3d8be5e..843e88b3cab8 100644
--- a/compiler-rt/lib/builtins/hexagon/dffma.S
+++ b/compiler-rt/lib/builtins/hexagon/dffma.S
@@ -104,13 +104,11 @@
         .type __hexagon_fmadf4, at function
 	.global __hexagon_fmadf5
         .type __hexagon_fmadf5, at function
-	.global fma
-	.type fma, at function
 	Q6_ALIAS(fmadf5)
 	.p2align 5
 __hexagon_fmadf4:
 __hexagon_fmadf5:
-fma:
+.Lfma_begin:
 	{
 		P_TMP = dfclass(A,#2)
 		P_TMP = dfclass(B,#2)
@@ -561,7 +559,7 @@ fma:
 		B = insert(BTMP,#63,#0)
 		AH -= asl(TMP,#HI_MANTBITS)
 	}
-	jump fma
+	jump .Lfma_begin
 
 .Lfma_ab_tiny:
 	ATMP = combine(##0x00100000,#0)
@@ -569,7 +567,7 @@ fma:
 		A = insert(ATMP,#63,#0)
 		B = insert(ATMP,#63,#0)
 	}
-	jump fma
+	jump .Lfma_begin
 
 .Lab_inf:
 	{

diff  --git a/compiler-rt/lib/builtins/hexagon/fabs_opt.S b/compiler-rt/lib/builtins/hexagon/fabs_opt.S
deleted file mode 100644
index 6bf9b84b3d20..000000000000
--- a/compiler-rt/lib/builtins/hexagon/fabs_opt.S
+++ /dev/null
@@ -1,36 +0,0 @@
-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fabs
-  {
-    r1 = clrbit(r1, #31)
-    jumpr r31
-  }
-FUNCTION_END fabs
-
-FUNCTION_BEGIN fabsf
-  {
-    r0 = clrbit(r0, #31)
-    jumpr r31
-  }
-FUNCTION_END fabsf
-
-  .globl fabsl
-  .set fabsl, fabs

diff  --git a/compiler-rt/lib/builtins/hexagon/fma_opt.S b/compiler-rt/lib/builtins/hexagon/fma_opt.S
deleted file mode 100644
index 7f566adffd6a..000000000000
--- a/compiler-rt/lib/builtins/hexagon/fma_opt.S
+++ /dev/null
@@ -1,30 +0,0 @@
-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fmaf
-  r2 += sfmpy(r0, r1)
-  {
-    r0 = r2
-    jumpr r31
-  }
-FUNCTION_END fmaf
-
-  .globl fmal
-  .set fmal, fma

diff  --git a/compiler-rt/lib/builtins/hexagon/fmax_opt.S b/compiler-rt/lib/builtins/hexagon/fmax_opt.S
deleted file mode 100644
index 81d711dff8d2..000000000000
--- a/compiler-rt/lib/builtins/hexagon/fmax_opt.S
+++ /dev/null
@@ -1,29 +0,0 @@
-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fmaxf
-  {
-    r0 = sfmax(r0, r1)
-    jumpr r31
-  }
-FUNCTION_END fmaxf
-
-  .globl fmaxl
-  .set fmaxl, fmax

diff  --git a/compiler-rt/lib/builtins/hexagon/fmin_opt.S b/compiler-rt/lib/builtins/hexagon/fmin_opt.S
deleted file mode 100644
index d043f1d7a698..000000000000
--- a/compiler-rt/lib/builtins/hexagon/fmin_opt.S
+++ /dev/null
@@ -1,29 +0,0 @@
-//===----------------------Hexagon builtin routine ------------------------===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-.macro FUNCTION_BEGIN name
-.text
-.p2align 5
-.globl \name
-.type  \name, @function
-\name:
-.endm
-
-.macro FUNCTION_END name
-.size  \name, . - \name
-.endm
-
-FUNCTION_BEGIN fminf
-  {
-    r0 = sfmin(r0, r1)
-    jumpr r31
-  }
-FUNCTION_END fminf
-
-  .globl fminl
-  .set fminl, fmin


        


More information about the llvm-commits mailing list