[PATCH] D83246: [Attributor] use liveness information from AAIsDead in AAReachability and cache query results

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I'm not sold on the liveness check. Do we have users of this function that would even try to call with a dead instruction? Usually, liveness is backed in so deep that all AAs actually see is assumed life.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:729
+    return Result;
+  }
+
----------------
Please add documentation and consider taking the instructions as references.

Nit: Move `F` after the first check to shorten the lifetime (and avoid confusion).



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:2312
+  bool isAssumedReachable(const Instruction *From, const Instruction *To,
+                          Attributor &A) const {
+    const auto &LivenessAA =
----------------
Style: Most our interfaces take the Attributor first (I think).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83246/new/

https://reviews.llvm.org/D83246