[PATCH] D83351: [llvm-reduce] Reducing attributes

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/Reduce/remove-call-site-attributes.ll:3
+;
+; RUN: rm -rf %t
+; RUN: llvm-reduce --test FileCheck --test-arg --check-prefixes=CHECK-ALL,CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
----------------
`rm -f %t` is sufficient.


================
Comment at: llvm/test/Reduce/remove-call-site-attributes.ll:20
+; CHECK-INTERESTINGNESS: %r = call
+; CHECK-INTERESTINGNESS: "attr0"
+; CHECK-INTERESTINGNESS: i32 @f1(
----------------
Add `-SAME:` if applicable


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp:155
+  });
+  sort(Res, [](const std::pair<unsigned, AttributeSet> &LHS,
+               const std::pair<unsigned, AttributeSet> &RHS) {
----------------
If it is non-deterministic, use `stable_sort`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351