[PATCH] D83351: [llvm-reduce] Reducing attributes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

One of the problems with bugpoint's attribute handling is it burns a lot of time trying to reduce attributes on intrinsics, which cannot actually be removed since getDeclaration will just put them back on



================
Comment at: llvm/tools/llvm-reduce/DeltaManager.h:36
   reduceOperandBundesDeltaPass(Tester);
+  reduceAttributesDeltaPass(Tester);
   // TODO: Implement the remaining Delta Passes
----------------
Doing this last is an improvement over bugpoint's attempt to do this first.

I don't think removing attributes is actually a great reduction strategy. For most of the hard to reduce testcases I debug, removing attributes is entirely pointless (and adding them is more helpful). I think this needs a flag to disable it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351