[llvm] 91f7067 - [X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70f3ed2a91e0a48c6448c517c3ba34c2846

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 15:21:34 PDT 2020


Author: Craig Topper
Date: 2020-07-07T15:20:59-07:00
New Revision: 91f70675cc6e5c872e0059c11d797b8726eeac67

URL: https://github.com/llvm/llvm-project/commit/91f70675cc6e5c872e0059c11d797b8726eeac67
DIFF: https://github.com/llvm/llvm-project/commit/91f70675cc6e5c872e0059c11d797b8726eeac67.diff

LOG: [X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70f3ed2a91e0a48c6448c517c3ba34c2846

I've added additional features to the table so I want to see if
the bots are happier with this.

Added: 
    

Modified: 
    llvm/include/llvm/Support/X86TargetParser.def
    llvm/lib/Support/X86TargetParser.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/X86TargetParser.def b/llvm/include/llvm/Support/X86TargetParser.def
index 91feb146baaa..9910fd615b1d 100644
--- a/llvm/include/llvm/Support/X86TargetParser.def
+++ b/llvm/include/llvm/Support/X86TargetParser.def
@@ -230,5 +230,6 @@ X86_FEATURE       (RETPOLINE_INDIRECT_BRANCHES, "retpoline-indirect-branches")
 X86_FEATURE       (RETPOLINE_INDIRECT_CALLS,    "retpoline-indirect-calls")
 X86_FEATURE       (LVI_CFI,                     "lvi-cfi")
 X86_FEATURE       (LVI_LOAD_HARDENING,          "lvi-load-hardening")
+X86_FEATURE       (SESES,                       "seses")
 #undef X86_FEATURE_COMPAT
 #undef X86_FEATURE

diff  --git a/llvm/lib/Support/X86TargetParser.cpp b/llvm/lib/Support/X86TargetParser.cpp
index 261e296b9e5a..df03f63e720e 100644
--- a/llvm/lib/Support/X86TargetParser.cpp
+++ b/llvm/lib/Support/X86TargetParser.cpp
@@ -441,6 +441,7 @@ static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_BRANCHES = {};
 static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_CALLS = {};
 static constexpr FeatureBitset ImpliedFeaturesLVI_CFI = {};
 static constexpr FeatureBitset ImpliedFeaturesLVI_LOAD_HARDENING = {};
+static constexpr FeatureBitset ImpliedFeaturesSESES = {};
 
 // XSAVE features are dependent on basic XSAVE.
 static constexpr FeatureBitset ImpliedFeaturesXSAVEC = FeatureXSAVE;
@@ -562,6 +563,7 @@ void llvm::X86::getImpliedFeatures(
   if (I == std::end(FeatureInfos)) {
     // FIXME: This shouldn't happen, but may not have all features in the table
     // yet.
+    assert(false && "Feature not found in table!");
     return;
   }
 


        


More information about the llvm-commits mailing list